Repository navigation
fix: Harden ama-logs ConfigMap handling - #1828
Open
Grace Wehner (gracewehner) wants to merge 7 commits into
Open
Grace Wehner (gracewehner) wants to merge 7 commits into
Grace Wehner (gracewehner) wants to merge 7 commits into
Conversation
Validate tenant and OSM values before generating parser configs, keep customer values literal, and run Telegraf with strict environment handling. Add regression coverage for injection and environment expansion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Drop the test that starts a local HTTP server to avoid DevSkim localhost findings. Keep default config coverage using a documentation-only address. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com
Keep environment references available to Telegraf while continuing to collect bounded reference telemetry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
Avoid plaintext HTTP URL findings in DevSkim by using HTTPS for inert parser test values. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com
Member
Author
|
/azp run |
Grace Wehner (gracewehner)
marked this pull request as ready for review
November 10, 2026 21:03
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Backdoor Testing Scenarios
tail_ignore_oldervalues survived; a value with a newline and command was rejected without execution.1s.10m/30m; the pods started with those safe values$NAMEand${NAME}forms for prometheus scrapingfielddropvalue did not create aninputs.execplugin or execute the marker.fielddropwere checked for Linux DaemonSet, ReplicaSet, sidecar and Windows rendering.fieldpass/fielddropmappings. Valid filtered and unfiltered scraping also ran in the cluster.