Repository navigation
Conversation
Reject partial Service Principal action inputs before starting deployment and enforce explicit SP selection in the child environment. Add isolated bundled-action regression coverage and prepare GitHub Actions v1.0.2. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ms-app-deploybefore launching the CLI when only some ofapp-id,client-secret, andtenant-idare supplied. Errors contain input names, not credential values; whitespace-only inputs count as missing through the Actions SDK's existing trimming behavior.Validation
1cbe5b72dc12b9f258f1ebc596d6cc69feb6d612rather than assuming the previously inspected source was current.child_process.spawn, records arguments/environment, and substitutes a synthetic CLI response; no real CLI, sign-in, or deployment is performed.cd github-actions && npm test(includes strict TypeScript compilation and rebuilding all action bundles).git diff --checkpasses.true,1,yes,on, mixed case/whitespace). Verifies inherited parent environment is unchanged.Scope and CLI boundary
This PR fixes the public CMR deployment action. It does not change
ms-app-pack(local packing), global CLI/account configuration, or CLI source. The coordinated CLI change must reject incomplete inherited SP configuration and selected-SP authentication failures without cached-identity fallback. Three absent/empty secrets remain indistinguishable from intentionally omitted inputs; no-input workflows continue to delegate identity selection to the CLI. This action fix can ship independently of the CLI change; the CLI fix is required for direct CLI and inherited-environment enforcement.