Repository navigation
fix(display): prevent decoration redraw flicker during external clipboard synchronization - #4258
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
…oard synchronization (micro-editor#4248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4248
Summary of Changes
Buffer Window Rendering State Tracking and Gating:
RenderStateininternal/display/bufwindow.gocapturing window geometry, viewport scroll coordinates, buffer modification status, cursor/selection bounds, and decoration states (active flag, dividers, scrollbar position, statusline string).GetRenderState(),ShouldRedraw(),NeedsRedraw(),Invalidate(),LastRenderState(), andSetRedrawDebounce()toBufWindow.BufWindow.Display()when visual state has not changed or when events occur without buffer modifications.External Clipboard Synchronization Gating and Debouncing:
internal/clipboard/clipboard.go(LastWrittencache) to prevent re-invoking external clipboard tools (such aswl-copy) when register contents are unchanged.SetWriteDebounce()and cache invalidation viaResetCache().RedrawDebounced()ininternal/screen/screen.goto coalesce rapid consecutive redraw triggers.StatusLine Text Inspection:
FormatText()andStatusString()onStatusLineininternal/display/statusline.goto provide deterministic statusline string inspection for render state comparison.Documentation:
wl-clipboarddocumentation toruntime/help/copypaste.mddetailing popup surface behavior under compositors withoutwlr-data-control, along with mitigation settings (clipboard terminal,useprimary false).Automated Unit Testing:
internal/display/bufwindow_test.goverifying buffer window rendering state initialization, change detection, display gating, buffer edit tracking, external clipboard synchronization without buffer edits, and decoration change responses.internal/clipboard/clipboard_test.goverifying duplicate write gating, debouncing, cache resets, and register tracking.