Repository navigation
fix(test): --watch does not re-run the suite against the old model after a failed rebuild - #1770
Merged
Merged
Conversation
…ter a failed rebuild A failed rebuild, injection or reparse fell through to the top of the loop, which ran the suite at once against the model from before the edit. The round is now an error result and the loop waits for the next change. The change baseline is taken at detection (and after the injection), so a save made during a failing rebuild starts a new round, and the run counter only counts rounds that ran. Fixes mendixlabs#1766 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1766
In
mxcli test --watch, a failed rebuild, failed test injection or failed parse now gives a red row with the error and the loop waits for the next change; it no longer reruns the suite against the previously built model and shows green.Tests:
go test ./cmd/mxcli/testrunnerpasses (also with-race -run Watch); new tests for a failed rebuild, a failed injection, and a save during a failing rebuild.🤖 Generated with Claude Code