Repository navigation
fix(run): a copied app folder's run state, handshakes and stored secrets - #1768
Merged
Merged
Conversation
.mxcli/run-state.json, run-local.json and test-endpoint.json record the project they were written for but nothing compared it, so a copy refused to start, run stop signalled the original's process, and test --attach used the original's app. All readers now ignore a file written for another project (SameProject: symlinks resolved, case-folded on macOS and Windows). --constant values, the password flags and the DatabasePassword and MicroflowConstants runtime settings are no longer written to the stored arguments, and the dev-loop handshake no longer carries MicroflowConstants (ApplyConstants replaces them). run restart refuses, saying why and naming the alternatives, when the stored arguments held a redacted secret. Fixes mendixlabs#1764 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1764
run-state.json,run-local.jsonandtest-endpoint.jsonrecord the project folder; state from another folder (a copy) is ignored with a message instead of blockingrunor lettingrun stopact on the original app (SameProjecthelper).run-state.json:--db-passwordand--runtime-setting DatabasePassword=/MicroflowConstants=are redacted.run-local.jsonstill holds the DB password (needed to re-apply constants) and is written 0600.Behaviour changes (in the CHANGELOG):
run restartof a run started with--db-passwordis refused, with instructions (PGPASSWORD, or rerunmxcli runwith the password).Tests: new redaction and same-project tests pass;
testrunnerandinternal/pathutilpass. Thecmd/mxcli/dockerpackage times out inharvest_test.goin my environment (10 min limit); this PR does not touch that package.🤖 Generated with Claude Code