Repository navigation
adjust page sizes - #163
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The limits are consistently applied, preserve existing defaults, and have focused unit coverage.
0 open findings
What changed in this PR
Caps REST max_txs overrides at configured page sizes to prevent oversized responses.
Changes:
- Adds a shared page-size capping helper.
- Applies caps across transaction and mempool pagination endpoints.
- Adds unit coverage and updates configuration help text.
| File | Description |
|---|---|
src/rest.rs |
Caps requested transaction counts and tests the helper. |
src/config.rs |
Clarifies that page-size settings are defaults and maximums. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
junderw
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.