Repository navigation
feat: symlink media/thumbs/key/<prefix>/<key> to thumbnail files - #1625
Merged
Merged
Conversation
Saving a thumbnail should leave thumbs/key/<prefix>/<key> pointed at the uuid jpeg so active files can be listed without the database. Co-authored-by: Cursor <cursoragent@cursor.com>
post_save keeps the link aligned after every media save. Deleting the thumbnail file removes that link even when the model is not saved. Co-authored-by: Cursor <cursoragent@cursor.com>
tcely
self-requested a review
October 28, 2026 09:00
tcely
added
enhancement
tcely
approved these changes
Oct 28, 2026
tcely
left a comment
tcely
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This all looks good to me.
tcely
added a commit
that referenced
this pull request
Oct 28, 2026
feat: symlink media/thumbs/key/<prefix>/<key> to thumbnail files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1621.
Problem
Thumbnail files live under
MEDIA_ROOT/thumbs/<uuid[:2]>/<uuid>.jpg, so listing which thumbs are still referenced by the database requires querying SQLite. A key-indexed symlink tree makes active thumbs a filesystem set difference.Approach
sync/thumb_key.pyhelpers that maintainMEDIA_ROOT/thumbs/key/<key[:2]>/<key>as a relative symlink to the uuid jpeg.sync_media_thumb_key_symlinkfrommedia_post_save.ImageFieldFilesubclass sothumb.delete(save=False)still removes the key link.No backfill command in this PR (new saves and deletes stay consistent; existing rows can be refreshed by re-saving thumbs later if wanted).
Verification
Tip:
43fbb49