Repository navigation
Union refactoring of scattering while loop #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lomholy
wants to merge
41
commits into
main
Choose a base branch
from
union_refactor_scattering_while_loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+380
−236
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
1958da6
Simplify Volume is only an absorber but not vacuum path in union master
Lomholy 59fac42
Gather focus preprocessing into its own function
Lomholy be52fe5
transfer non isotropic wavevector rotation into its own function
Lomholy 8d0c557
Make inhomogenous sampling loop more transparent by moving most logic…
Lomholy e45e91b
Move inhomogenous distance sampling to a function
Lomholy e322f23
Move p_interact behaviour and inhomogenous scattering point sampling …
Lomholy 3128fbb
Move process choice after scattering into functions for p_interact an…
Lomholy 78189d5
Move using forced length to scatter from to a separate function
Lomholy 6550419
fix p being used instead of weight in dir length function
Lomholy 4265eef
Fix pointer magic that resulted in only writing to the first value of…
Lomholy 17a1be5
Assign scattering length for inhomogenous process
Lomholy 4b687fc
Apply mccode-clangformat to Union_master.comp
Lomholy 12041c4
Rename choose scattering point and direction, to reflect that it is o…
Lomholy abc7514
fix erroneus if statements inside process_needs_inhomogenous sampling
Lomholy c25937c
Add pointer dereference to scattering_event inside safeguard function
Lomholy 0e155de
Remove erroneously placed symbolic link to Union master
Lomholy 3f8a4f0
Add pointer dereference to scattering_event inside safeguard function…
Lomholy e45afc6
Change debug statement from using Volumes array to using correct Volu…
Lomholy c29d82f
regularize naming conventions across the functions for the logic path…
Lomholy f5dd909
Merge branch 'main' into union_refactor_scattering_while_loop
willend b430a0b
Merge branch 'main' into union_refactor_scattering_while_loop
willend 8f0a606
Move the helper functions from Union master to union-lib.c
Lomholy 25f8659
Use copying of values instead of pointer passing for doubles and ints…
Lomholy b1baae7
Merge upstream/main into union_refactor_scattering_while_loop
mads-bertelsen-agentic a99f57c
Merge pull request #2753 from mads-bertelsen-agentic/union-refactor-f…
Lomholy 8b2bb9b
Set initialization of sampling points to -1 both in physics struct an…
Lomholy c597437
Simplify the k_rotated in accordance with review
Lomholy 7340f63
Rename mu_at_speed to mu_abs_at_speed
Lomholy 4bb4c3e
Pass _particle to inhomogeneous_sample_scattering point
Lomholy 373b056
invert logic in inhomogeneous position sampling for loop
Lomholy 261df9c
Remove erroneous multiplication by dist in weight correction for samp…
Lomholy a89b367
Pass the particle to the p_interact logic paths, and fix a missing pa…
Lomholy f2c073c
Remove unnecessary if statement, add comment instead
Lomholy f11f560
Remove needs_numerical integration from union-lib.h since the paramet…
Lomholy abc9457
Add missing brackets to if statement with break included
Lomholy 1f4629b
Remove needs_numerical_integration as it is no longer in use
Lomholy 5afae3e
total_mus was implicitly using the cross section times the distance, …
Lomholy 33149a5
Remove unnecessary if statement
Lomholy 5bc7408
Remove unnecessary current_p in front of physics as it is inside a fu…
Lomholy 6d4606a
Flip process inhomogeneous condition in probability function
Lomholy c436073
Merge branch 'main' into union_refactor_scattering_while_loop
Lomholy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.