Skip to content

Finished route focusing - #124

Open
iswheeler wants to merge 1 commit into
navigation-hubfrom
improved-bus-details
Open

iswheeler wants to merge 1 commit into
navigation-hubfrom
improved-bus-details

Conversation

@iswheeler

Copy link
Copy Markdown
Contributor

Description

Added bus route highlighting to the map! Now when you click on a bus (or choose "See all stops for this bus" from the stop sheet), it highlights the bus polyline and stops while turning the rest gray.

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Refactor / code improvement
  • Dependency / build update
  • Documentation
  • Other (explain)

Changed Files

(Please list all files you changed, each with a description of what you changed and why.)
Tip: see a list of everything you changed on the "Files changed" tab

Example:

  • map_screen.dart
    • Made the BusSheet modal half height and added calls to baseRoutesLayer.setFocusedRoute(...) whenever the bus sheet is shown
  • onboarding_screen.dart
    • Disabled the scrim to avoid the background darkening as the user scrolls the BusSheet.
  • base_routes_layer.dart
    • Added a focusedRoute variable to track which route is focused, and it now influences how polylines and stops are drawn (non-focused-route polylines are gray, and non-focused-route stops are hidden)

Related Issues

Does your code rely on another PR

Testing Done

Flutter:

  • Tested on:
    • iOS Simulator
    • Android Emulator
    • Physical device

Screenshots / Demo (if UI or notification change)

route_highilght_v2.mp4

Checklist

  • Commit messages follow Conventional Commits
  • PR title follows [type](scope): short description
  • PR target branch is not main and is our current working update branch (e.g. maizebus2.1)
  • No print() / debugPrint() / console.log() left in production code
  • Secrets / keys not committed

@sahusw sahusw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on iOS simulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants