Repository navigation
Conversation
mathiasrw
added this pull request to stack #787
October 23, 2026 09:45
mathiasrw
force-pushed
the
fix/808
branch
5 times, most recently
from
October 23, 2026 10:11
c712c76 to
5af4b94
Compare
mathiasrw
marked this pull request as draft
October 23, 2026 10:25
mathiasrw
marked this pull request as ready for review
October 23, 2026 10:26
mathiasrw
marked this pull request as draft
October 23, 2026 10:40
mathiasrw
marked this pull request as ready for review
October 23, 2026 10:42
mathiasrw
force-pushed
the
fix/808
branch
4 times, most recently
from
October 23, 2026 10:51
220bd70 to
53dfae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #808
Stacked on #807.
Change
When the code of
--jsfails, only the message is told, as a panic:Before, the stack trace of the runtime showed all the code put in front of the code of the user (the numbers of #791 with their cousins), about a screen long.
errorsin the status report.Also in this PR
The help for
--simulatesays: "Execute everything during a run except changes RexReplace would normally make to the file system. Code from --js still runs, and can change data even with --simulate." (This PR gave it another text. #838 changed it to this one.)Tests
yarn test-cipasses: the demo on Node and Bun, and 1024 Bun tests.test/fix/808.test.jsis new. Five tests expected the error of the code to come out of the engine, and now check the message and the exit code 3.