Skip to content

Remove --pipe, as --js-pipe does the same, to close #794 - #800

Merged
mathiasrw merged 1 commit into
mainfrom
fix/794
Oct 23, 2026
Merged

mathiasrw merged 1 commit into
mainfrom
fix/794

Conversation

@mathiasrw

Copy link
Copy Markdown
Owner

Closes #794

Stacked on #786.

Change

  • --pipe (-p) is gone. It gave the piped data to the code of --js as pipe, and did nothing useful without --js. --js-pipe does the same, and is the one to use.
  • -p is free.
  • The warning "Data is piped in, but no flag tells what to do with it" is gone. Only --pipe could give it: without files the piped data is the content, and with files the pipe is only read when a flag asks for it, and all the other flags use it.
  • The help and the README say --js-pipe where they said --pipe.
  • The devguide table of the output functions is up to date: panic() and not die(), the exit codes 1, 2 and 3, and checkFailed().

Tests

  • test/cli/pipe.test.js tests --js-pipe, and that --pipe and -p are unknown (exit code 3).
  • test/fix/719.test.js is gone with the warning, and so is the line in run.sh. The status report test for warnings uses 0 files found.
  • yarn test-ci passes: the demo on Node and Bun, and 976 Bun tests.

@mathiasrw
mathiasrw added this pull request to stack #787 October 23, 2026 09:45
Base automatically changed from fix/782 to main October 23, 2026 09:50
@mathiasrw
mathiasrw marked this pull request as draft October 23, 2026 09:51
@mathiasrw
mathiasrw marked this pull request as ready for review October 23, 2026 09:53
@mathiasrw
mathiasrw merged commit 1fcccd7 into main Oct 23, 2026
7 checks passed
@mathiasrw
mathiasrw deleted the fix/794 branch October 23, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove --pipe, as --js-pipe does the same

1 participant