Repository navigation
Conversation
mathiasrw
added this pull request to stack #765
October 23, 2026 00:30
mathiasrw
force-pushed
the
fix/689
branch
2 times, most recently
from
October 23, 2026 00:35
5e26c51 to
2554bb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689
Stacked on #748. Merge that first.
Change
--replacement-jsdoes not use a captured group, it still runs only once per file, but its result is given toString.replacefrom a function. The result of a function is never expanded, so$&,$$,$`and$'in it are inserted as they are. This is how it already worked when a group is used.--output-matchthe code of--replacement-jsis not run, as the replacement prints the matches. This is now said indoReplacement(). Before, it only worked becauseeval()of the--output-matchfunction gave the function back.test.todofor Result of--replacement-jsgets$&and$$expanded #689 is now a real test.