Skip to content

Give size as 0 Bytes for empty content in --replacement-js to close #687 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathiasrw merged 1 commit into from
Oct 23, 2026
Merged

Give size as 0 Bytes for empty content in --replacement-js to close #687 #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ function readableSize(size) {
if (1 === size) {
return '1 Byte';
}
const i = Math.floor(Math.log(size) / Math.log(1024));
// 0 has no logarithm, so it is counted in bytes
const i = size ? Math.floor(Math.log(size) / Math.log(1024)) : 0;
return (
(size / Math.pow(1024, i)).toFixed(!!i ? 1 : 0) + ' ' + ['Bytes', 'KB', 'MB', 'GB', 'TB'][i]
);
Expand Down
2 changes: 1 addition & 1 deletion test/js/replacement-js.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ describe('--replacement-js', () => {
expect(await js('foobar', 'bytes + "|" + size', 'foobar')).toBe('6|6 Bytes');
});

test.todo('BUG #687: size of empty content is "0 Bytes"', async () => {
test('size of empty content is "0 Bytes" (#687)', async () => {
expect(await inFile('bytes + "|" + size', '')).toBe('0|0 Bytes');
});

Expand Down
Loading