Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #742
Change
src/cli.tssets the exit code and ends the process.files.searched,files.updated,pipe(bytes,type,updated),warningsanderrors. It is collected as the run goes, also when the quiet flags hide the messages.die()and--haltthrow a panic in place ofprocess.exit(). The engine adds the status so far, and the CLI exits with 1.--statusprints the status report as JSON with an indent of two spaces, after a line break.--status-compact(-S) prints it on one line.--verbosethe status report also hasengine: the version, the runtime, the config as it came in, what the regex engine was asked to do and the steps of the run.--debug(-d) prints only the status report, with what went into the engine and what it did.--quietdoes not hide--verbose.--quiet-totalhides it.debug(),step()) is removed. The three lines that only--debugshowed are now told by--verbose.on('data').Tests
rr()intest/js/helper.jsstill gives{out, err, exit}.rrStatus()gives the status report of the same run. A spy onprocess.exitfails the test if the engine ends the process.test/js/fix/742.test.jstests the status report, the pipe types, panics, theenginepart and the CLI flags.test/js/debug.test.jstests the new--debugwith the CLI.