Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #728
Change
error()counts the errors of the run, andengine()resolves with the number of errors. The engine does not touch the exit code.process.exitCode = 1when the engine resolves with errors. The run goes on, and the process ends with 1 when the last file is done.--haltstill stops at the first error.--quietand--quiet-totalonly hide the message. The exit code is the same.--halt0 files foundEACCESon open)Tests
rr()intest/js/helper.jsgivesexit: 1when the engine resolves with errors, like the CLI.exit: nullafter an error now expectexit: 1.--halttests show what--haltchanges: the other files are left alone with it, and handled without it.-qand-Qintest/cli/run.ai.share turned on.Later
process.exit().