Repository navigation
Qualify hostile sentinel and terminality checks with source controls - #30
Open
rowan-claude wants to merge 3 commits into
Open
rowan-claude wants to merge 3 commits into
rowan-claude wants to merge 3 commits into
Conversation
…coverage Co-Authored-By: GPT-6
Co-Authored-By: GPT-6
Co-Authored-By: GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hostile-read fuzzer used one scalar sentinel, skipped the boolean destination check, and tested terminality only with a one-bit read. A fresh boolean destination clobber and an int64 operation that incorrectly succeeded after refusal each passed the old oracle. This change adds complementary full-width destination patterns, checks boolean and 128-bit destinations, admits empty payloads, and independently probes zero-bit operations after every refusal.
The deterministic gate proves first-refusal coverage for 28 named read cases under both patterns, including later members of grouped wide/unsigned reads and the read after an accepted end. Nine independent post-refusal probes cover degenerate int/int64/int128/fixed/fixed128, alignment, empty bytes, end, and object composition. Each checks result, position, reason, and scalar destination or callback invocation.
Sixteen source controls modify private copies of the actual reader: seven destination writes that preserve the first pattern, plus one broken latch for each of the nine zero-bit APIs. Each must fail the same primary oracle with its expected diagnostic. CI runs replay and all controls with assertions enabled and disabled. Production sources and wire bytes are unchanged.
Validation on Linux Hulk, Temurin 21.0.12.1+1, Java 17 language level:
make test test-release controls: 576 tests/14,534 checks checked; 562 tests/14,406 checks release; all 18 conformance controls hold.make fuzz-sentinel-controls: 7,777 inputs, 28 first-refusal cases under each pattern, and 32 expected control detections across checked/release.Logs are retained in
/tmp/stella-serialize-java-cold-20261102/review-logs/on Hulk. Source workspace:/Volumes/nova/ai/stella/working/serialize-java-cold-20261102on Studio.