Repository navigation
docs(fork): say that GitHub marks the sync pull request merged when main moves - #40
Merged
Merged
Conversation
…ain moves Force-pushing a sync branch to main makes the review pull request's head main's tip, so GitHub marks it merged and gh pr close refuses it. Step 7 said to close it, which sent agents to check why it could not be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of the rewrite in
agents/dev/instructions.mdsaid to close the review pull request after force-pushingsync/<date>tomain. That can't be done. The push makes the pull request's headmain's tip, so GitHub marks it merged, andgh pr closerefuses: "can't be closed because it was already merged". Agents keep running into this and stop to work out why, as happened when applying #39.Step 7 now says that GitHub marks the pull request merged, so it needs no closing, and to comment that the rewrite is applied.
Only
agents/dev/instructions.mdchanges. Prettier passes on it. Per the fork's process, this lands onmainas a squash merge and folds into the setup commit at the next rewrite.