Repository navigation
Let register_card send the customer back to redirect URLs - #4
Merged
Merged
Conversation
Epoint's card-registration takes success_redirect_url and error_redirect_url, and the sandbox honours them, but register_card never sent them, so a card saved without a payment could not bring the customer back to the merchant's page. Both arguments are now accepted by the sync and async clients and fall back to the client defaults, as the pay methods already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
/api/1/card-registrationtakes optionalsuccess_redirect_urlanderror_redirect_url. The sandbox honours both, butregister_cardnever sent them.register_cardinEpointClientandAsyncEpointClientaccepts both arguments. When they are not given, it falls back to the client'ssuccess_redirect_urlanderror_redirect_urldefaults, as the pay methods do. With neither set, nothing is sent, the same as before.The version bump and changelog follow in a separate release PR.