Repository navigation
Fix crash on quoted anonymous function names - #690
Merged
Merged
Conversation
Reproduces macbre#688: a quoted function name such as "timezone"(...) crashes column extraction with AttributeError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
exp.Anonymous.this is an Identifier when the function name is quoted, so calling .lower() on it raised AttributeError. Use .name, which sqlglot normalises to a str for both forms. Resolves macbre#688. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quoted function name like
"timezone"(...)makesexp.Anonymous.thisanIdentifier, so the date-part check crashed calling.lower()on it. It now uses.name, which is a str for both forms. The first commit adds the regression test.Resolves #688.
🤖 Generated with Claude Code