Repository navigation
fix: mcc infra update exits after restarting in detached mode; align api.yaml framework versions - #226
Merged
Conversation
conf/api.yaml, conf/docker/api.yaml, web-console 마운트용 api.yaml에 남아 있던 이전 version 값을 docker-compose.yaml에 고정된 이미지 태그로 맞춘다. - mc-observability(-fe) 0.7.0 - mc-application-manager(-fe) 0.7.1 - mc-workflow-manager(-fe) 0.7.1 - mc-cost-optimizer(-fe) 0.6.5 - mc-data-manager(-fe) 0.7.3 -fe 항목은 같은 framework 이미지(observability-front, costopti-ui 포함)를 가리키므로 같은 버전으로 둔다.
- update에 -d 플래그가 등록되지 않아(run 전용 detachFlag 참조) 항상 포그라운드 docker compose up으로 붙어 명령이 끝나지 않던 문제 수정 - 재기동은 항상 up -d로 실행, pull/up 모두 SysCallWithError + RunE로 실패 시 0이 아닌 종료코드 반환 (pull 실패 시 재기동하지 않음) - bin/mcc, conf/docker/tool/mcc 재빌드 - docs/mc-admin-cli-infra.md에 update 동작 안내 추가
fix: mcc infra update가 detach로 재기동하고 종료되도록 수정
…ramework-versions
…rsions chore: api.yaml의 framework version을 compose 고정 이미지 버전과 일치시킴
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcc infra update: images are pulled and the containers are restarted in detached mode, so the command now exits when the update is done. Pull and restart failures return a non-zero exit code.versionfields in the three api.yaml files now match the image tags pinned indocker-compose.yaml.1.
mcc infra updatenever exitedBefore:
update.goadded-dtodocker compose uponly whendetachFlagwas set. That variable belongs torun, and the-dflag is registered only onrunCmd(./mcc infra update --helpshows only-s). As a result,updatealways attached todocker compose upand never returned. Pressing Ctrl+C to leave stopped the target containers. Pull and restart errors were also ignored, and the command exited 0.After (
src/cmd/docker/update.go):docker compose up -d <service>, and the command exits once the containers are restarted.Run→RunE,SysCall→SysCallWithError, the same handlingrunalready uses. A failed pull skips the restart and returns a non-zero exit code../mcc infra infoordocker logscan be used to check them.docs/mc-admin-cli-infra.md: one line explaining the update behavior.Rebuilt binaries:
bin/mccandconf/docker/tool/mcc(defaultsrc/Makefiletarget). The binaries had not been rebuilt since0f4f991, so this rebuild also ships the earlier source fixes already onmain: setup credential CSP keys (#97 on MZC-CSC) andmcc rest postsending POST (#98 on MZC-CSC).Behavior change:
mcc infra updateno longer follows the container logs. Use./mcc infra run(attached) ordocker logs -f <container>to follow logs.2. Align api.yaml framework versions with the pinned images
conf/api.yaml,conf/docker/api.yamlandconf/docker/conf/mc-web-console/api/conf/api.yaml(mounted into the web console as/conf/) still had olderversionvalues:-feentries point to the same framework release, so they use the same version.versionin the three files matches its image tag indocker-compose.yaml(0 mismatches). mc-infra-connector 0.13.17, mc-infra-manager 0.13.6 and mc-iam-manager / mc-web-console 0.7.0 were already aligned.versionis registry metadata (it is registered by1_setup_auto.shfromMC_ADMIN_CLI_APIYAML, which points toconf/api.yamlonmain). There is no change in call behavior.