Skip to content

fix: mcc infra update exits after restarting in detached mode; align api.yaml framework versions - #226

Merged
MZC-CSC merged 6 commits into
m-cmp:mainfrom
MZC-CSC:develop
Oct 14, 2026
Merged

MZC-CSC merged 6 commits into
m-cmp:mainfrom
MZC-CSC:develop

Conversation

@MZC-CSC

@MZC-CSC MZC-CSC commented Oct 14, 2026

Copy link
Copy Markdown
Member

Summary

  1. mcc infra update: images are pulled and the containers are restarted in detached mode, so the command now exits when the update is done. Pull and restart failures return a non-zero exit code.
  2. api.yaml framework versions: the version fields in the three api.yaml files now match the image tags pinned in docker-compose.yaml.

1. mcc infra update never exited

Before: update.go added -d to docker compose up only when detachFlag was set. That variable belongs to run, and the -d flag is registered only on runCmd (./mcc infra update --help shows only -s). As a result, update always attached to docker compose up and never returned. Pressing Ctrl+C to leave stopped the target containers. Pull and restart errors were also ignored, and the command exited 0.

After (src/cmd/docker/update.go):

  • The restart always runs docker compose up -d <service>, and the command exits once the containers are restarted.
  • Run → RunE, SysCall → SysCallWithError, the same handling run already uses. A failed pull skips the restart and returns a non-zero exit code.
  • The help text says the containers are restarted in detached mode and that ./mcc infra info or docker logs can be used to check them.
  • docs/mc-admin-cli-infra.md: one line explaining the update behavior.

Rebuilt binaries: bin/mcc and conf/docker/tool/mcc (default src/Makefile target). The binaries had not been rebuilt since 0f4f991, so this rebuild also ships the earlier source fixes already on main: setup credential CSP keys (#97 on MZC-CSC) and mcc rest post sending POST (#98 on MZC-CSC).

Behavior change: mcc infra update no longer follows the container logs. Use ./mcc infra run (attached) or docker logs -f <container> to follow logs.

2. Align api.yaml framework versions with the pinned images

conf/api.yaml, conf/docker/api.yaml and conf/docker/conf/mc-web-console/api/conf/api.yaml (mounted into the web console as /conf/) still had older version values:

Service Before (api.yaml / web-console mount) After
mc-observability, mc-observability-fe 0.5.0 / 0.4.0, v0.0.1 0.7.0
mc-application-manager(-fe) 0.5.2 / 0.4.0, v0.0.1 0.7.2
mc-workflow-manager(-fe) 0.5.1 / 0.4.0, v0.0.1 0.7.2
mc-cost-optimizer(-fe) 0.5.2 / 0.4.0 0.7.0
mc-data-manager(-fe) 0.5.3 / 0.4.0, v0.0.1 0.7.3
  • -fe entries point to the same framework release, so they use the same version.
  • After this change every version in the three files matches its image tag in docker-compose.yaml (0 mismatches). mc-infra-connector 0.13.17, mc-infra-manager 0.13.6 and mc-iam-manager / mc-web-console 0.7.0 were already aligned.
  • version is registry metadata (it is registered by 1_setup_auto.sh from MC_ADMIN_CLI_APIYAML, which points to conf/api.yaml on main). There is no change in call behavior.

yh-noh and others added 6 commits October 14, 2026 08:18
conf/api.yaml, conf/docker/api.yaml, web-console 마운트용 api.yaml에 남아 있던 이전 version 값을 docker-compose.yaml에 고정된 이미지 태그로 맞춘다.

- mc-observability(-fe) 0.7.0
- mc-application-manager(-fe) 0.7.1
- mc-workflow-manager(-fe) 0.7.1
- mc-cost-optimizer(-fe) 0.6.5
- mc-data-manager(-fe) 0.7.3

-fe 항목은 같은 framework 이미지(observability-front, costopti-ui 포함)를 가리키므로 같은 버전으로 둔다.
- update에 -d 플래그가 등록되지 않아(run 전용 detachFlag 참조) 항상
  포그라운드 docker compose up으로 붙어 명령이 끝나지 않던 문제 수정
- 재기동은 항상 up -d로 실행, pull/up 모두 SysCallWithError + RunE로
  실패 시 0이 아닌 종료코드 반환 (pull 실패 시 재기동하지 않음)
- bin/mcc, conf/docker/tool/mcc 재빌드
- docs/mc-admin-cli-infra.md에 update 동작 안내 추가
fix: mcc infra update가 detach로 재기동하고 종료되도록 수정
- upstream main m-cmp#224(cost-optimizer 0.7.0)·m-cmp#225(AM·WM 0.7.2) 이미지 고정에 맞춰
  conf/api.yaml, conf/docker/api.yaml, web-console 마운트용 api.yaml의
  mc-application-manager(-fe)·mc-workflow-manager(-fe) → 0.7.2,
  mc-cost-optimizer(-fe) → 0.7.0
…rsions

chore: api.yaml의 framework version을 compose 고정 이미지 버전과 일치시킴
@MZC-CSC
MZC-CSC merged commit df95dc0 into m-cmp:main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants