Skip to content

Linux: fix Wayland window border and AppImage/dock icon - #57

Open
randombenj wants to merge 1 commit into
logseq:version/filefrom
randombenj:linux-wayland-appimage-fixes
Open

randombenj wants to merge 1 commit into
logseq:version/filefrom
randombenj:linux-wayland-appimage-fixes

Conversation

@randombenj

Copy link
Copy Markdown
  • Electron 41.7.1 → 42.11.18: fixes the extra border around frameless windows on Wayland (electron#51456, fixed in 42.9.3 by electron#52584; never backported to 41). Also bumps better-sqlite3 to 12.11.1, since 12.10.0 doesn't compile against Electron 42.
  • AppImage icon: electron-forge-maker-appimage always uses Electron's default icons. A preMake hook replaces them with Logseq icons (linux, 16–256px).
  • Dock icon on Wayland: "desktopName": "Logseq OG.desktop" makes the Wayland window ID Logseq OG, matching the AppImage's StartupWMClass. Before this, the window reported logseq-og, so the dock couldn't match it and showed the Electron icon.

Note: plugins already fail to load on Electron ≥ 40 (including the current 41.7.1), so this PR doesn't fix them; #50 addresses that.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant