Repository navigation
ci: release automatically from conventional commits - #63
Conversation
|
szymeo
left a comment
There was a problem hiding this comment.
Lead review: no blocking findings (release computes 1.1.0, publish runs only after all test legs, permissions minimal, tarball clean). Two small fixes before merge:
.github/workflows/pr-title.yml: addpermissions: {}abovejobs:, so the title check gets no token it does not use (the repo default is write)..github/workflows/ci.ymlaround line 78: the comment says a failed run retries, which only holds whennpm publishfails. Ifgh release createfails after a successful publish, later runs compute the same version and fail at publish until that tag exists. Say so in the comment, with the recovery:gh release create v<version> --generate-notes --target <sha that was published>.
…ional Commits, in one PR
szymeo
left a comment
There was a problem hiding this comment.
One more, replacing the comment-only fix for ci.yml ~78: make the release re-runnable instead. Skip npm publish when the version is already on npm ([ "$(npm view "@logdash/node@$V" version 2>/dev/null)" = "$V" ] || npm publish --access public), then tag, so a rerun after a failed gh release create just tags. Keep the comment, reworded to match.
szymeo
left a comment
There was a problem hiding this comment.
One more small one: scripts/version.ts line ~4 still names tony's Info.plist. Say that the package.json version is the placeholder CI overwrites before packaging.
…ional Commits, in one PR
…ional Commits, in one PR
Summary
ci: release automatically from conventional commits
Publish
malini/01J70771BFAA8174668A5045BAagainstmain..github/workflows/approval.ymlValidation