Skip to content

ci: release automatically from conventional commits - #63

Merged
szymeo merged 4 commits into
mainfrom
malini/01J70771BFAA8174668A5045BA
Oct 25, 2026
Merged

szymeo merged 4 commits into
mainfrom
malini/01J70771BFAA8174668A5045BA

Conversation

@szymeo

@szymeo szymeo commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Summary

ci: release automatically from conventional commits

Publish malini/01J70771BFAA8174668A5045BA against main.

  • .github/workflows/approval.yml

Validation

  • Passed - Validation: vitest; tsc
  • Passed - Validation: node --test 'scripts/.test.ts'; node --test scripts/.test.ts
  • Passed - Validation: node --test scripts/*.test.ts; pnpm build; pnpm lint; pnpm test
  • Passed - Validation: pnpm run lint
  • Passed - Validation: pnpm build
  • Passed - Validation: pnpm build; pnpm build; pnpm run lint; pnpm run test; node --test 'scripts/*.test.ts'

@changeset-bot

changeset-bot Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e8fadf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@szymeo szymeo mentioned this pull request Oct 24, 2026

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lead review: no blocking findings (release computes 1.1.0, publish runs only after all test legs, permissions minimal, tarball clean). Two small fixes before merge:

  • .github/workflows/pr-title.yml: add permissions: {} above jobs:, so the title check gets no token it does not use (the repo default is write).
  • .github/workflows/ci.yml around line 78: the comment says a failed run retries, which only holds when npm publish fails. If gh release create fails after a successful publish, later runs compute the same version and fail at publish until that tag exists. Say so in the comment, with the recovery: gh release create v<version> --generate-notes --target <sha that was published>.

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more, replacing the comment-only fix for ci.yml ~78: make the release re-runnable instead. Skip npm publish when the version is already on npm ([ "$(npm view "@logdash/node@$V" version 2>/dev/null)" = "$V" ] || npm publish --access public), then tag, so a rerun after a failed gh release create just tags. Keep the comment, reworded to match.

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small one: scripts/version.ts line ~4 still names tony's Info.plist. Say that the package.json version is the placeholder CI overwrites before packaging.

Comment thread .github/workflows/pr-title.yml
@szymeo
szymeo marked this pull request as ready for review October 25, 2026 01:43
@szymeo
szymeo merged commit a02dfa1 into main Oct 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant