Repository navigation
fix(simulations): commit scenario ids to scenarios.yaml - #112
Merged
Merged
Conversation
lk v2.19.0 requires an `id` on the scenario group and on every scenario. Without them, the simulations workflow fails in CI with "scenarios.yaml is missing 4 scenario id(s); re-run with --yes to have them added to the file", and a local run stops to ask whether to rewrite the file. The ids were generated by `lk agent simulate text --scenarios scenarios.yaml -y`.
bcherry
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since lk v2.19.0, a scenarios file needs an
idon the group and on every scenario, so LiveKit can track a scenario across runs as its text changes. This starter'sscenarios.yamlhas none, so:.github/workflows/simulations.ymlfails on its first run:scenarios.yaml is missing 4 scenario id(s); re-run with --yes to have them added to the file.lk agent simulate text --scenarios scenarios.yamllocally stops at an "Add scenario IDs?" prompt that rewrites the file you just cloned.Fix
Commit the ids. They were generated by the CLI itself (
lk agent simulate text --scenarios scenarios.yaml -y). Nothing else in the file changes.Verification
With lk built from livekit-cli main, against a staging project, all 3 scenarios ran and passed.