Skip to content

chore(i18n): remove redundant ar_EG translations, keep ar - #97

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:chore/remove-ar_EG-translations
Sep 20, 2026
Merged

BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:chore/remove-ar_EG-translations

Conversation

@BLumia

@BLumia BLumia commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

The ar_EG (Egyptian Arabic) translation files are redundant variants of the existing ar (Arabic) translations. All build systems use glob patterns to collect .ts files, so removing these files has no impact on the build. The corresponding *_ar.ts files remain in place.

Files removed:

  • translations/dde-session-shell_ar_EG.ts

See: DDE-333

Summary by Sourcery

Enhancements:

  • Remove the redundant Egyptian Arabic translation catalog while retaining the standard Arabic translations.

@sourcery-ai

sourcery-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Deletes the redundant ar_EG translation file so the project retains only the existing ar translations; glob-based build discovery means no build configuration changes are required.

File-Level Changes

Change Details Files
Remove the redundant Egyptian Arabic translation catalog while retaining the canonical Arabic catalog.
  • Delete the obsolete locale-specific translation file.
  • Continue using the existing Arabic translations collected by the build glob patterns.
translations/dde-session-shell_ar_EG.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit 8ac5ca7 into linuxdeepin:master Sep 20, 2026
13 of 16 checks passed
@BLumia
BLumia deleted the chore/remove-ar_EG-translations branch September 20, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants