(bug) fix issues where asspan() and indexer might return out-of-range data - #323
Merged
linkdotnet merged 3 commits intoOct 4, 2026
Merged
Conversation
Owner
|
Uhh good point - the check is (or now: was) wrong. Feel free to add yourself to CHANGELOG.md under "UNRELEASED". I can also take this over - let me know. In any case, thanks for the contribution. |
linkdotnet
approved these changes
Oct 3, 2026
Contributor
Author
|
Hi @linkdotnet , I've updated the changelog. Thanks for reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am an user of the library so I would like to contribute with some improvements.
This PR adds the range guards for
AsSpan()and indexer methods.Currently, the data was returned even if it is outside of
bufferPositionrange.This PR adds a guard to make the method throws when such data is requested.