process_events_async_with_kv_store_sync isn't actually usable #4111

Activity

1. TheBlueMatt

   added this to the 0.2 milestone on Sep 23, 2025
2. tnull commented on Sep 24, 2025

   

   tnull

   on Sep 24, 2025

   Last edited by tnull

   Contributor

   More actions

   It requires a OS: Deref<Target = OutputSweeper<T, D, F, CF, KVStoreSyncWrapper<K>, L, O>>, but you can't get such an object from an OutputSweeperSync outside of a test environment (and we don't really want to expose it). Not sure how to fix this, but we need to....

   Well, the title isn't entirely accurate as we use it in LDK Node pre-lightningdevkit/ldk-node#633. I think you can get such a monstrosity via OutputSweeper::new_with_kv_store_sync (see https://github.com/lightningdevkit/ldk-node/blob/65945f8e25ef7d1f6a621115f814678a661470ce/src/builder.rs#L1613).

   I'm still in favor of dropping process_events_async_with_kv_store_sync altogether though.

   👀React with 👀1Reacted by Matt Corallo
3. TheBlueMatt commented on Sep 24, 2025

   

   TheBlueMatt

   on Sep 24, 2025

   CollaboratorAuthor

   More actions

   Bleh, that's borderline unsafe - having blocking IO in something that pretends to be async is not a great outcome.
4. TheBlueMatt commented on Sep 25, 2025

   

   TheBlueMatt

   on Sep 25, 2025

   CollaboratorAuthor

   More actions

   Fixed in #4119.
5. TheBlueMatt

   closed this as completedon Sep 25, 2025