Repository navigation
Can we merge Channel::tx_complete and Channel::funding_tx_constructed? #3609
Description
Looks like we can? I think we maybe didn't because at the time those were written we didn't have the Channel-can-switch-state-internally stuff done, but now that we do we can probably merge them? cc @dunxen
Activity
dunxen commentedon Feb 19, 2025
Yes, that's probably possible now. I'll leave it for after #3423.
wpaulino commentedon Jan 29, 2026
I don't think this is relevant anymore,
Channel::funding_tx_constructedis only called in one place and that'sChannel::tx_complete.TheBlueMatt commentedon Jan 30, 2026
If its only called in one place that seems like an ideal thing to inline?
TheBlueMatt commentedon Feb 19, 2026
Dual funding is gonna slip yet again, setting to 0.4