Repository navigation
Introduce Runtime object allowng to detect outer runtime context - #543
Merged
tnull merged 1 commit intoAug 18, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #491
Instead of holding an
Arc<RwLock<Option<Arc<tokio::runtime::Runtime>>>and dealing with stuff like
tokio::task::block_in_placeat allcallsites, we introduce a
Runtimeobject that takes care of the statetransitions, and allows to detect and reuse an outer runtime context.
We also adjust the
with_runtimeAPI to take atokio::runtime::Handlerather than an
Arc<Runtime>.We then also go ahead an reuse saidRuntimeobject forVssStore.(cc @andrei-21)