Repository navigation
Conversation
|
👋 I see @TheBlueMatt was un-assigned. |
Collaborator
Author
|
Reassigning @tankyleo. |
ajaysehwal
reviewed
Oct 15, 2026
Some live-node APIs still relied on helper methods to reject calls while stopped, leaving lifecycle validation inconsistent across the public API. Reject stopped-node calls at each public entry point and remove the helper checks. Keep unified payment rechecks before dispatch so a stop during asynchronous resolution is still detected. Cover the payment variants with offline assertions that stopped calls return NotRunning. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-10-outer-api-running-checks
branch
from
October 16, 2026 13:36
8b76e56 to
a3a1c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small follow-up to #1160.
Some live-node APIs still relied on helper methods to reject calls while stopped, leaving lifecycle validation inconsistent across the public API.
Reject stopped-node calls at each public entry point and remove the helper checks. Keep unified payment rechecks before dispatch so a stop during asynchronous resolution is still detected.