Repository navigation
Fix stop-gap recovery test assumptions - #1154
Merged
Merged
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
joostjager
reviewed
Oct 14, 2026
joostjager
previously approved these changes
Oct 14, 2026
joostjager
left a comment
joostjager
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock CI, but still curious about the +5
Recent BDK clients count the full-scan stop gap only after the wallet's revealed range. The recovery test funded an address within that range plus the default gap, so its zero-balance assertion failed. Place the funds beyond the startup address pool and default gap, allowing for batched requests. Keep the configured gap wide enough for older clients too, preserving both recovery assertions. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-10-fix-full-scan-stop-gap
branch
from
October 15, 2026 07:55
bff8753 to
2f82cf9
Compare
joostjager
approved these changes
Oct 15, 2026
joostjager
left a comment
joostjager
left a comment
Contributor
There was a problem hiding this comment.
// Also cover older BDK clients, which count revealed-but-unused scripts toward the gap.
feels a bit strange now because no exception is made in the code line below.
But it's good enough as is I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent BDK clients count the full-scan stop gap only after the wallet's revealed range. The recovery test funded an address within that range plus the default gap, so its zero-balance assertion failed.
Place the funds beyond the startup address pool and default gap, allowing for batched requests. Keep the configured gap wide enough for older clients too, preserving both recovery assertions.
Co-Authored-By: HAL 9000