Repository navigation
Switch to use bitcoin-payment-instructions #521
Description
Now that https://github.com/rust-bitcoin/bitcoin-payment-instructions has been moved to the rust-bitcoin org, we should replace parts of our QR-code scanning etc code with it, and contribute any changes that might become necessary upstream.
Activity
Camillarhi commentedon May 25, 2025
Hi @tnull ,
I've opened a draft PR (#546) for integrating
bitcoin-payment-instructions. While working on this, I wanted to clarify the intended handling of configurable amounts:Currently in the draft:
ConfigurableAmountPaymentInstructionsFixedAmountPaymentInstructionsCould you share how you envision configurable amounts being handled in practice? I want to make sure the integration aligns with it.
Happy to adapt the implementation based on your guidance.
Camillarhi commentedon May 25, 2025
Hi @tnull,
My PR currently uses a
DummyHrnResolversince proper HRN resolution isn't implemented yet.From the code and #528, it looks like its resolver implementation is required to replace this dummy.
Just confirming - is #528 indeed the dependency that'll provide the real resolver implementation we should eventually swap in?
tnull commentedon May 26, 2025
@Camillarhi Thanks for showing interest for this, but indeed, this seems to conflict with the in-progress HRN integration work, as part of which we're currently discussing how the final integration should even look like. I think it makes more sense to not consider this an entirely separate task but rather doing it after/as part of the HRN work, sorry!
To avoid duplicate work in the future, please try to indicate first that you're interested in a particular task.
Camillarhi commentedon May 26, 2025
Hi @tnull,
Thanks for the clarification, and I appreciate you pointing this out. I completely understand the need to coordinate first to avoid duplicate work, I’ll be sure to signal my interest in tasks upfront moving forward.
Since the HRN integration is already being handled, I’ll keep an eye on its progress and look for other areas where I might contribute. If there are other tasks that could use help while the HRN implementation is in progress, please let me know, I'd be happy to assist elsewhere in the meantime.
Thanks again for your guidance!
tnull commentedon Jul 1, 2025
This will now need to be prioritized as we decided to handle HRN resolution in LDK Node based on rust-bitcoin/bitcoin-payment-instructions#6
Camillarhi commentedon Jul 1, 2025
Hi @tnull, I’d still love to contribute to this effort, let me know if there’s a specific part of the integration I can pick up.
tnull commentedon Jul 1, 2025
Well, as mentioned above, this will be worked up as part of the HRN work by @chuksys.
chuksys commentedon Jul 1, 2025
Added this to #557