Skip to content

Pin surge-ping to 0.8: 0.9.1 needs 64-bit atomics - #22

Open
BKPepe wants to merge 2 commits into
masterfrom
deps/surge-ping-32bit
Open

BKPepe wants to merge 2 commits into
masterfrom
deps/surge-ping-32bit

Conversation

@BKPepe

@BKPepe BKPepe commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

surge-ping 0.9.1 reaches for AtomicU64, which does not exist where
max-atomic-width is 32 — 32-bit PowerPC and MIPS, so mpc85xx, ath79 and
ramips. Reported: kolapapa/surge-ping#77

Master has failed there since a059533 with unresolved import std::sync::atomic::AtomicU64; 1.2.0 shipped 0.8.4 and is unaffected.
0.9.1's fixes concern cloned clients and cancelled pings, neither of which
this client does.

The new matrix entry reproduces the failure on 0.9.1 and passes on 0.8.4.
It checks rather than builds, because the cross image carries libatomic
for PowerPC without the symlink a link step needs.

It reaches for AtomicU64, which does not exist where max-atomic-width is
32: 32-bit PowerPC and MIPS, so mpc85xx, ath79 and ramips in OpenWrt.
Back to 0.8.4, the version 1.2.0 shipped, until the crate stops needing a
64-bit atomic.
Copilot AI lite review requested due to automatic review settings September 27, 2026 16:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Every target in the matrix had 64-bit atomics, so a dependency that needs
them built everywhere and broke only on the boards OpenWrt cares about.
powerpc-unknown-linux-gnu is the same shape as mpc85xx. It needs -latomic,
or the binary links and CI stays green while the loader cannot start it, so
the artifact is started under qemu. The cache key gains the matrix entry as
well: it named only the job, and entries restored each other's targets.
@BKPepe
BKPepe force-pushed the deps/surge-ping-32bit branch from c9d2f17 to 08a2aad Compare September 28, 2026 05:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants