Conversation
When all selected servers are down, exit 1 and report each server's failure to stderr instead of emitting an empty report. Runs with at least one successful server still exit 0. ServerStatus keeps up and gains down_reason.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on librespeed/speedtest-cli#153, the same change for the Go client.
When every selected server is unreachable (for example a cached
--local-json list on a link that is down), the client printed an empty
report (null, a result event carrying null, or an empty CSV line) and
exited 0 with nothing on stderr, so a wrapper could not tell why the
measurement failed.
When all selected servers are down, the run now exits 1 and reports
each server's failure to stderr instead of emitting an empty report.
Runs with at least one successful server still exit 0. ServerStatus
keeps
upand gainsdown_reason, so code that builds it with everyfield listed needs the new one.
Until the parity tests' pinned Go build includes
librespeed/speedtest-cli#153, the parity cases declare this as a difference (
Why::DownServerFails), and the READMEsays so; both go away once the pin moves.
Tested with cargo fmt, clippy -D warnings, a native-tls check and cargo
test, including the parity run against the Go client.