Repository navigation
ci: name what a refused submission got wrong - #10
Merged
Merged
Conversation
The check wrote its findings only to the run's summary page, so a refused submission's log ended on whatever go printed last and read like a failed download. Every blocking finding is now also written as an error annotation and every note for the reviewer as a warning, which puts the reason in the log, on the pull request and in gh pr checks.
The check runs once per area, the entry itself, the repository, the manifest, services, images, code and installing it beside the listed plugins, each as its own step. The step that goes red names what is wrong, and an entry that cannot be fetched skips the rest instead of repeating the same error in each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refused submission's log ended on whatever go printed last, here a module download, and the reason sat only on the run's summary page, as on #4. The check now writes every blocking finding as an error annotation and every note for the reviewer as a warning, so the reason shows in the log, on the pull request and in gh pr checks. It also runs once per area, the entry, the repository, the manifest, services, images, code and installing beside the listed plugins, each a step of its own, so the step that goes red names what is wrong, and an entry that cannot be fetched skips the rest rather than repeating the same error.