Repository navigation
Read the TipTap editor's page direction from window.isRTL - #6343
Open
rtibblesbot wants to merge 5 commits into
Open
rtibblesbot wants to merge 5 commits into
rtibblesbot wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The handle is placed with inset-inline-end, so under the editor's dir="auto" it follows the content direction, which can differ from the page's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`[dir='rtl']` ignored the editor's `dir="auto"` content direction, and RTLCSS flipped both cursor rules in the RTL bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RTLCSS flipped both transform-origin rules in the RTL bundle, and `[dir='rtl']` ignored the editor's dir="auto" content direction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
End-aligned images put the handle on their inline-start edge, the one that moves; centered images grow by twice the drag distance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6114-0e03f0
branch
from
October 26, 2026 19:59
3a480cf to
81ab15f
Compare
rtibblesbot
marked this pull request as ready for review
October 26, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.isRTL, as toolbar arrow keys already did.dir="auto").References
Fixes #6114. Raised in: #6108 (comment)
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/image/ImageNodeView.vue,contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/ToolbarButton.vue,contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/composables/useLinkHandling.js.direction, which leaves the issue's two "one source" criteria unmet, or must readwindow.isRTL.[dir='rtl']cursor andtransform-originrules rewritten as:dir(rtl)withrtl:ignore, plus LTR resize changes for right-aligned and centered images.QA team: the toolbar and image resize handle follow the text direction. Regressions are most probable in image resize.
Open an exercise you can edit, Questions tab. Click "Edit" on a question, then click its text.
Toolbar in Arabic
Focus moves to إعادة (Redo). Numbered list, Subscript and Superscript show numbers on the left.
Image resize in English and Arabic UI
Without text, a right-aligned image has the handle at the bottom left. With Arabic text, the handle is on the image side nearer the editor middle. The diagonal cursor points along the handle corner. The handle stays under the pointer. An outward drag makes the image larger. Below 200 px, smaller edit and delete buttons show at the top right, or top left with Arabic text. Save and reopen the question. The width and alignment stay.
Uploaded image after reload
Manual QA cannot reach the link editor, because it does not open in the question editor.
Evidence
Image resize, English UI
s5-english-ui-resize-handle.webm
Image resize, Arabic UI
s6-arabic-ui-resize-handle.webm
Toolbar
Image alignment
ar-rtl-content-align-toggle-resize.webm
More captures (13)
AI usage
Used Claude Code to implement the change and its tests. Verified with the TipTap editor Jest suite, pre-commit, and manual QA in Chromium.
🤖 Generated with Claude Code
Deviations from the issue spec
window.isRTLreversed the drag in 4 of 6 page/content direction mixes.directionon the handle.Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-10-26 20:32 UTC