Skip to content

Move workflows to Node 22 and upgrade googleapis to 186 - #124

Merged
rtibbles merged 2 commits into
learningequality:mainfrom
rtibblesbot:issue-123-36d65d
Oct 26, 2026
Merged

rtibbles merged 2 commits into
learningequality:mainfrom
rtibblesbot:issue-123-36d65d

Conversation

@rtibblesbot

@rtibblesbot rtibblesbot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • googleapis 178.1.1+ requires Node ≥22, so its Dependabot bump failed yarn install --frozen-lockfile on Node 20
  • All setup-node steps use Node 22; googleapis bumped to 186.0.0
  • yarn test uses a glob: Node 22's node --test treats a directory argument as a file

References

Fixes #123. Supersedes #120.

Reviewer guidance

Suggested review: Full code review.

  • Workflow steps changed: .github/workflows/contributor-issue-comment.yml, .github/workflows/contributor-pr-reply.yml, .github/workflows/good-first-issue-comment.yml, .github/workflows/holiday-message.yml, .github/workflows/is-contributor.yml, .github/workflows/manage-issue-header.yml, .github/workflows/pr-statistics.yml, .github/workflows/pre-commit.yml, .github/workflows/pull-request-label.yml, .github/workflows/pull-request-template.yml, .github/workflows/review-requested.yml, .github/workflows/sync-automation-template.yml, .github/workflows/test.yml, .github/workflows/unassign-inactive-issues.yaml, .github/workflows/update-pr-spreadsheet.yml.
  • The real Sheets write path (google-auth-library 9 → 11, gaxios 6 → 8) only runs with production secrets, and a dry_run dispatch returns before authorize(), so check that the first scheduled run after merge succeeds.
  • Node 22 reaches end-of-life in April 2027, and actions/github-script@v9 already runs on Node 24, so confirm 22 is the version to pin.

AI usage

Used Claude Code to update the workflow pins, regenerate the lockfile and fix the test script. Verified with the full test suite, eslint, yarn install --frozen-lockfile and loading the spreadsheet script.

🤖 Generated with Claude Code

Deviations from the issue spec

Criterion Why not
dry_run dispatch completes on Node 22 Needs the workflow's secrets on the upstream repo; a maintainer dispatches it after merge.

Written by rtibblesbot, an LLM-based coding agent.

@rtibblesbot

🟡 Waiting for feedback

Last updated: 2026-10-25 22:35 UTC

rtibblesbot and others added 2 commits October 25, 2026 15:31
- googleapis >=178.1.1 requires Node >=22
- `node --test scripts/` runs no tests on Node 22; glob the test files

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rtibblesbot
rtibblesbot marked this pull request as ready for review October 25, 2026 22:34
@rtibblesbot
rtibblesbot requested review from a team and leq-bot October 25, 2026 22:34
@rtibbles
rtibbles merged commit 59bdf58 into learningequality:main Oct 26, 2026
158 checks passed
@rtibblesbot

Copy link
Copy Markdown
Contributor Author

Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific.

@rtibblesbot
rtibblesbot deleted the issue-123-36d65d branch October 26, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move workflows to Node 22 and upgrade googleapis to 186

2 participants