Skip to content

Works with Flutter Desktop Windowing (multiple windows) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlBlanc wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Works with Flutter Desktop Windowing (multiple windows) #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98f391f
Introducing flutter native windowing API
AlBlanc Oct 5, 2026
493f2cf
Introducing flutter desktop windowing API for macos
AlBlanc Oct 5, 2026
c6813cb
Fix window_manager type
AlBlanc Oct 9, 2026
5cdee71
Test
AlBlanc Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/window_manager/macos/window_manager/Sources/window_manager/WindowManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,16 @@ extension NSRect {

public class WindowManager: NSObject, NSWindowDelegate {
public var onEvent:((String) -> Void)?

private var registrar: FlutterPluginRegistrar?

private var _mainWindow: NSWindow?
public var mainWindow: NSWindow {
get {
return _mainWindow!
if let window = _mainWindow {
return window
}
return (registrar?.view?.window)!
}
set {

@AlBlanc AlBlanc Oct 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me if I am wrong but this setter does not seem to be relevant anymore. We should remove it and also remove _mainWindow attribute

_mainWindow = newValue
Expand All @@ -68,8 +73,9 @@ public class WindowManager: NSObject, NSWindowDelegate {
private var _isPreventClose: Bool = false
private var _isMaximized: Bool = false
private var _isMaximizable: Bool = true

override public init() {

public init(_ registrar: FlutterPluginRegistrar) {
self.registrar = registrar
super.init()
}

Expand Down
18 changes: 7 additions & 11 deletions ...ages/window_manager/macos/window_manager/Sources/window_manager/WindowManagerPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,21 @@ public class WindowManagerPlugin: NSObject, FlutterPlugin {
return (self.registrar.view?.window)!;
}
}

private var _inited: Bool = false
private var windowManager: WindowManager = WindowManager()

private var windowManager: WindowManager

public init(_ registrar: FlutterPluginRegistrar, _ channel: FlutterMethodChannel) {
super.init()
self.registrar = registrar
self.channel = channel
self.windowManager = WindowManager(registrar)
self.windowManager.onEvent = {
(eventName: String) in
self._emitEvent(eventName)
}
}

private func ensureInitialized() {
if (!_inited) {
windowManager.mainWindow = mainWindow
windowManager.onEvent = {
(eventName: String) in
self._emitEvent(eventName)
}
_inited = true
}
}

public func handle(_ call: FlutterMethodCall, result: @escaping FlutterResult) {
Expand Down
Loading