Repository navigation
Run the regression suites out of sight and wait for the colour popup - #59
Merged
Merged
Conversation
WinForms keeps dropdowns and tooltips on a screen even when a suite places their owner off-screen, so test runs flashed popups in the screen corners and could take focus. Run-Tests.ps1 now starts every suite on a hidden desktop of its own; -VisibleDesktop runs them on the current one. SettingsEditors pumped messages only once after clicking the colour swatch and occasionally found no popup yet, failing with a NullReferenceException. It now waits up to two seconds and reports "Colour popup did not open".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SettingsEditorsoccasionally failed with aNullReferenceExceptioninvisiblePopup(): oneDoEventsafter clicking the colour swatch was not always enough for the popup to show.What
tests/Run-Tests.ps1creates a hidden desktop per run and starts every suite on it (child processes such asPrintWindowHelperinherit it).-VisibleDesktopkeeps the old behaviour for watching a run.visiblePopupintests/SettingsEditors.fsxpumps messages for up to 2 s and fails with "Colour popup did not open" if none appears.Verification
Run-Tests.ps1 -Suites SettingsEditors -Repeat 5passes 5/5.-VisibleDesktopstill runs (WindowIcon).-Coverage; CI covers it.