Repository navigation
Keep combined taskbar previews in tab order - #57
Merged
Merged
Conversation
These windows join their group, leave it and join again as they start. The returning preview could be registered by Explorer after the order that places it and showed first. Previews are now unregistered before they are destroyed, and a changed order is sent again once settled.
…anges A preview window kept its window class and pinned procedure until its whole group closed, so groups whose tabs come and go kept collecting them. Previews are now unregistered before the group's taskbar window goes, and titles, positions and the active preview are sent only when they change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Combine taskbar icons on, the taskbar previews of a Neovide or Alacritty group showed the newest tab first instead of last.
These apps join their group as "Neovide"/"Alacritty", leave it as untabbable a moment later and join again under the file's title. The removed preview was destroyed without
UnregisterTab, and Explorer could register the returning preview after the order that places it.Verified with real Neovide and Alacritty windows: before, the newest tab's preview came first; after, the previews match the tab order.
GroupLifecyclechecks that a preview that leaves and rejoins is ordered again, and that 20 such cycles leave no windows behind.