Repository navigation
Slim the Python test suite by a third (coverage unchanged) - #328
Merged
Merged
Conversation
…ther tests Selected from per-test coverage (--cov-context=test, branch mode): each file's tests cover no argus/ line or branch that the remaining suite does not. Files added since 2026-10-23, release_tools, canvas and named-regression tests were never candidates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Removes copy-paste variants first (all lines and branches covered by a sibling in the same file), then tests fully covered elsewhere; tests that mention an incident, regression, trial, bug or dated finding, and tests added in the last week, are kept. Helpers and imports left unused are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…aemon Same selection rule as the life/core batch. Also stops the Popen-counting test in test_workspace_v2 from counting a spawn made by another test's leftover thread (it failed once in a full run when ordering changed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same selection rule: only tests whose lines and branches stay covered by the rest of the suite; recent, named-regression and protected files untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts the Python test suite by about a third while keeping argus/ line coverage the same. No source file changes.
Numbers (origin/dev 5ebebb5 vs this branch)
--cov-branch)-n 16, no coverage-n 16, with coverageCoverage went up by noise (+0.015 pt): the removed tests cover no line or branch that the remaining suite misses.
How tests were chosen
--cov-context=test --cov-branch, so every test has its own set of argus/ lines and branch arcs.tests/release_tools/test_review_once.py,test_effort_policy.py,test_liveness_operator.py,webapi/test_canvas*.py,webapi/test_map_trace_relations.pyconftest.pyruff --fixcleaned up imports. A file is deleted only when it has no tests left and no other test imports from it.What was removed, by kind:
Removed lines by directory (approx.):
tests/root: 11.6klife: 11.6kwebapi: 8.8kcore: 7.8kskills: 4.2kmanager: 4.2ktrial: 3.2kdaemon: 2.4kapps: 2.2kOne small test fix:
webapi/test_workspace_v2.py::test_workspace_git_portable_pipe_reads_are_bounded_and_reapedmonkeypatchessubprocess.Popenglobally and counted a spawn from another test's leftover thread once when test order changed. It now counts only spawns from its own thread.Checks
-n 16, with coverage.tests/trial/test_gateway*concurrency tests fail now and then under-n 16load on both dev and this branch. They pass on both with-p no:xdist.ruff check argus testsis clean.--codethis branch, run 20261024-110351): 19/20 on the first run. The miss was k1-split-cents (checks 6/7), and it is not caused by this PR: the branch changes no file outsidetests/, so the Argus code is byte-identical to dev. In that run the team asked about rounding and negatives, the operator answered "negatives and >2 decimals raise ValueError", and the delivered code used the team's own first proposal instead. Rerunning only k1 (run 20261024-112139) passed 7/7, 0 oddities. That makes it 20/20 across the two runs. The ignored answer looks like a real product flake on dev and is worth its own look.Merge after review; no source or release artifacts touched.
🤖 Generated with Claude Code