Skip to content

Map status tells the truth after closing steps stop (rule 6) - #323

Merged
lbx154 merged 1 commit into
devfrom
fix/overview-truth
Oct 24, 2026
Merged

lbx154 merged 1 commit into
devfrom
fix/overview-truth

Conversation

@lbx154

@lbx154 lbx154 commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Project s-7d7b7d22 (research survey) showed contradictory status on the map. The survey was delivered and passed independent review, but the header read 已完成 · 这一步执行未完成 with the hint 这次工作未完成, and the map said 1 项需要你处理.

Causes

  • The latest item is 681aae2979d7, a repair of Argus's own .argus/ records that failed on a supervisor error (git fetch origin main). Before it came closing items: three superseded and one (12dedb2805cb) aborted by the operator. currentWorkStatus reported task_failed for that housekeeping step, and teamPhase mapped every step_finished to "done", so 已完成 appeared next to "did not finish".
  • attentionTasks counted that failed .argus/-only step. It also had no explicit guard for operator aborts or superseded items recorded as failed.
  • Compact snapshot backlog rows had no owns_paths, so the UI had no way to tell housekeeping apart from the person's own work.
  • 主要成果: on current dev, this data already shows the reviewed survey, because the server maps the completion event to the reviewer role. As a safeguard, a completion with delivery candidates now also counts when the task's latest independent review passed, even if the completion is attributed to the engineer. The reviewer's verdict wins over a missing receipt.

Fix

  • A step that did not finish reads 已停止, never 已完成.
  • A failed step whose owns_paths are all under .argus/ ends the step without "task failed" (rule 7). These steps, operator-aborted steps, and superseded steps no longer count as needing the reader.
  • Compact backlog rows now carry owns_paths.
  • The failed-step hint now says 这一步未完成 and that delivered results are kept.

The map card for the failed step stays red, so the failure is still visible.

Verification

  • Ran a private copy of the state on port 8993 with token dev and no model calls. The header now reads 已完成 · 这一步已结束. 主要成果 shows reward-hacking-survey-zh.md (已审查), and there is no attention link.
  • Web vitest: 1420 passed. tsc passed.
  • pytest tests/webapi and tests/release_tools passed. ruff passed. Release artifacts rebuilt.
  • New tests in mapOverview.test.tsx and test_results_and_files.py use this data shape.

🤖 Generated with Claude Code

On s-7d7b7d22 the survey was delivered and passed independent review, then
closing steps were superseded, one was aborted by the operator, and the
last (a repair of Argus's own .argus/ records) failed on a supervisor error.
The header said 已完成 next to 这一步执行未完成 / 这次工作未完成, and
"1 项需要你处理" counted that housekeeping step.

- teamPhase: a step that did not finish reads 已停止, never 已完成.
- currentWorkStatus: a failed step whose owns_paths are all under .argus/
  is housekeeping (rule 7); it ends the step without "task failed".
- attentionTasks: aborted-by-operator, superseded, and .argus/-only failed
  steps no longer count as needing the reader.
- projectOverview: a completion with delivery candidates counts as a
  reviewed result when the task's latest independent review passed, even if
  older records attribute the completion to the engineer layer.
- compact snapshot backlog rows carry owns_paths.
- Failed-step hint says 这一步未完成 and that delivered results are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lbx154
lbx154 merged commit e6ecb9a into dev Oct 24, 2026
4 of 5 checks passed
@lbx154
lbx154 deleted the fix/overview-truth branch October 24, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant