Repository navigation
Map status tells the truth after closing steps stop (rule 6) - #323
Merged
Merged
Conversation
On s-7d7b7d22 the survey was delivered and passed independent review, then closing steps were superseded, one was aborted by the operator, and the last (a repair of Argus's own .argus/ records) failed on a supervisor error. The header said 已完成 next to 这一步执行未完成 / 这次工作未完成, and "1 项需要你处理" counted that housekeeping step. - teamPhase: a step that did not finish reads 已停止, never 已完成. - currentWorkStatus: a failed step whose owns_paths are all under .argus/ is housekeeping (rule 7); it ends the step without "task failed". - attentionTasks: aborted-by-operator, superseded, and .argus/-only failed steps no longer count as needing the reader. - projectOverview: a completion with delivery candidates counts as a reviewed result when the task's latest independent review passed, even if older records attribute the completion to the engineer layer. - compact snapshot backlog rows carry owns_paths. - Failed-step hint says 这一步未完成 and that delivered results are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project s-7d7b7d22 (research survey) showed contradictory status on the map. The survey was delivered and passed independent review, but the header read 已完成 · 这一步执行未完成 with the hint 这次工作未完成, and the map said 1 项需要你处理.
Causes
681aae2979d7, a repair of Argus's own.argus/records that failed on a supervisor error (git fetch origin main). Before it came closing items: three superseded and one (12dedb2805cb) aborted by the operator.currentWorkStatusreportedtask_failedfor that housekeeping step, andteamPhasemapped everystep_finishedto "done", so 已完成 appeared next to "did not finish".attentionTaskscounted that failed.argus/-only step. It also had no explicit guard for operator aborts or superseded items recorded as failed.owns_paths, so the UI had no way to tell housekeeping apart from the person's own work.Fix
owns_pathsare all under.argus/ends the step without "task failed" (rule 7). These steps, operator-aborted steps, and superseded steps no longer count as needing the reader.owns_paths.The map card for the failed step stays red, so the failure is still visible.
Verification
tests/webapiandtests/release_toolspassed. ruff passed. Release artifacts rebuilt.mapOverview.test.tsxandtest_results_and_files.pyuse this data shape.🤖 Generated with Claude Code