Skip to content

removed opacity and updated shading - #1862

Open
vivekmaurya001 wants to merge 1 commit into
layer5io:masterfrom
vivekmaurya001:visibility-text
Open

vivekmaurya001 wants to merge 1 commit into
layer5io:masterfrom
vivekmaurya001:visibility-text

Conversation

@vivekmaurya001

@vivekmaurya001 vivekmaurya001 commented Oct 7, 2026 •

Copy link
Copy Markdown

Notes for Reviewers

This PR fixes #1805
removed extra fading and maded disabled button text darker

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Style
    • Permission-restricted content retains its existing opacity while remaining non-interactive.
    • Disabled contained and outlined buttons now use secondary text coloring; their backgrounds and outlined borders are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1334e1f2-1928-4e92-9ce6-39b261645b08
📥 Commits

Reviewing files that changed from the base of the PR and between 672bc14 and 36d21d6.

📒 Files selected for processing (2)
  • src/custom/permissions.tsx
  • src/theme/components/button.modifier.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The changes adjust opacity handling in PermissionShield and text colors for disabled contained and outlined buttons. The disabled button backgrounds and outlined border remain unchanged.

Changes

Disabled control appearance

Layer / File(s) Summary
Disabled control styling
src/theme/components/button.modifier.ts, src/custom/permissions.tsx
Disabled contained and outlined buttons now use the secondary text color. PermissionShield no longer reduces child opacity, while its wrapper continues to disable pointer events.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: leecalcote

Merge Risk: ⚪ Minimal · up to 36d21

The disabled labels appear to meet the requested light-mode readability goal. No merge-blocking issue is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #1805 requires readable text in the light-mode Native Button Gating demo. src/custom/permissions.tsx removes the 0.5 opacity from PermissionShield children while retaining `pointerEvents: 'n…
Out of Scope Changes check ✅ Passed Both changes support issue #1805: one removes fading from permission-gated content, and the other improves disabled-button text contrast. The wider button style change applies the fix to both containe…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes both changes: removing child opacity reduction and updating disabled-button text shading. It is concise and relevant to the pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unreadable text on Native Button Gating demo in light mode

1 participant