Skip to content

fix(optimization): pin LD-API-Version on agent-optimization API calls (AIC-3484) #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffdupont merged 2 commits into from
Sep 28, 2026
Merged

fix(optimization): pin LD-API-Version on agent-optimization API calls (AIC-3484) #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d902b
[AIC-3484] fix: pin LD-API-Version on agent-optimization API calls
jeffdupont Sep 28, 2026
fa7b6c3
fix(optimization): inline the pinned LD-API-Version value
jeffdupont Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/optimization/src/ldai_optimizer/ld_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ def __repr__(self) -> str:
return f"LDApiClient(base_url={self._base_url!r})"

def _auth_headers(self) -> Dict[str, str]:
return {"Authorization": self._api_key}
return {
"Authorization": self._api_key,
"LD-API-Version": "20240415",
}

def _request(
self,
Expand Down
8 changes: 8 additions & 0 deletions packages/optimization/tests/test_ld_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,14 @@ def test_authorization_header_always_sent(self):
req: urllib.request.Request = mock_open.call_args[0][0]
assert req.get_header("Authorization") == "my-api-key"

def test_default_api_version_header_is_v4(self):
client = LDApiClient("test-key")
with patch("urllib.request.urlopen", return_value=_mock_urlopen({})) as mock_open:
client._request("GET", "/path")
req: urllib.request.Request = mock_open.call_args[0][0]
# urllib capitalizes header names; the wire value is still LD-API-Version.
assert req.get_header("Ld-api-version") == "20240415"

def test_raises_ld_api_error_on_http_error(self):
client = LDApiClient("test-key")
http_error = urllib.error.HTTPError(
Expand Down
Loading