Skip to content

Fix typos in README.md, main.go and pkg/hook/hook.go - #1010

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jah-yee:fix/typos-specifid-commmit-chanel
Nov 2, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jah-yee:fix/typos-specifid-commmit-chanel

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes three spelling mistakes in the git-sync repository:

  1. README.md (line 297) and main.go (line 2679) — the --exechook-timeout flag description reads "If the timeout for the --exechook-command is not specifid"; changed specifid to specified.
  2. main.go (line 1531) — the comment above the worktree HEAD check reads "Make sure it is synced to the right commmit."; changed commmit to commit.
  3. pkg/hook/hook.go (line 161) — the doc comment for sendOneTimeResultAndTerminate reads "closes said chanel"; changed chanel to channel.

Why

These are user-facing: the --exechook-timeout wording appears in git-sync --help output via the main.go usage text, so specifid is visible to anyone reading the flag documentation.

Testing

Documentation/comment-only change — no behavior is altered. go build ./... and go vet ./... pass locally on the branch.

Notes for reviewers

The README.md flag table and the main.go usage string are kept in sync, so both were corrected together. Happy to split the commit or drop any part if you prefer a narrower change.

README.md and main.go: "not specifid" -> "not specified" for the
--exechook-timeout flag description.
main.go: "right commmit" -> "right commit" in the worktree sync check.
pkg/hook/hook.go: "closes said chanel" -> "closes said channel".
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @Jah-yee!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow
kubernetes-prow Bot requested review from sdowell and thockin October 31, 2026 21:48
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2026

@sdowell sdowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jah-yee, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit ce9f731 into kubernetes:master Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants