Skip to content

Remove Jackson serialized from IntOrString, use default JSON - #4990

Open
brendandburns with Copilot wants to merge 3 commits into
masterfrom
copilot/migrate-to-jackson-3
Open

brendandburns with Copilot wants to merge 3 commits into
masterfrom
copilot/migrate-to-jackson-3

Conversation

Copilot AI commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Consumers may need to avoid Jackson 2 in their dependency tree while retaining the existing serialization behavior. Keep the Jackson 2 serializer as the default and allow consumers to provide a per-ObjectMapper alternative without changing existing interfaces.

  • Default: Preserve the existing Jackson 2 serialization for IntOrString.
  • Customization: Use a Jackson mix-in to select a custom serializer:
    @JsonSerialize(using = MyIntOrStringSerializer.class)
    abstract class IntOrStringMixin {}
    
    mapper.addMixIn(IntOrString.class, IntOrStringMixin.class);
  • Dependency: Mark jackson-databind optional so consumers can manage their own Jackson dependencies.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

CLA Not Signed

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2026
Copilot AI linked an issue Nov 5, 2026 that may be closed by this pull request
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2026
Copilot AI changed the title [WIP] Migrate to Jackson 3 and update dependency requirements Make the IntOrString Jackson serializer pluggable Nov 5, 2026
Copilot AI requested a review from brendandburns November 5, 2026 18:05
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@brendandburns
brendandburns marked this pull request as ready for review November 8, 2026 20:03
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from yue9944882 November 8, 2026 20:03
@brendandburns brendandburns changed the title Make the IntOrString Jackson serializer pluggable Remove Jackson serialized from IntOrString, use default JSON Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Jackson 3

2 participants