Skip to content

fix(mining): avoid libc++ header path in source location - #12

Closed
PastaPastaPasta wants to merge 1 commit into
knst:perf-sync-p1from
PastaPastaPasta:codex/fix-7934-stdlib-path
Closed

PastaPastaPasta wants to merge 1 commit into
knst:perf-sync-p1from
PastaPastaPasta:codex/fix-7934-stdlib-path

Conversation

@PastaPastaPasta

Copy link
Copy Markdown

Summary

  • construct the gsl::not_null block-index argument before std::optional::emplace
  • keep the captured source location in Dash code instead of libc++'s construct_at.h

This fixes the macOS check-stdlib-paths failure for dashpay#7934.

Testing

  • make -C src -j8
  • /tmp/lief-venv/bin/python contrib/guix/stdlib-path-check.py src/dashd src/qt/dash-qt
  • make -C src -j8 test/test_dash
  • ./src/test/test_dash --run_test=evo_dip3_activation_tests
  • test/lint/lint-whitespace.py

This pull request was created by Codex.

@PastaPastaPasta
PastaPastaPasta requested a review from knst as a code owner October 26, 2026 03:10
@PastaPastaPasta PastaPastaPasta changed the title fix(build): avoid libc++ header path in miner source location fix(mining): avoid libc++ header path in source location Oct 26, 2026
@knst

knst commented Oct 26, 2026

Copy link
Copy Markdown
Owner

inline changes to dashpay#7934

@knst knst closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants