Repository navigation
feat: Allow forcing a refresh of the comments list - #124
Merged
Merged
Conversation
Dispatch commentions:refresh to reload the list immediately, e.g. after saving a record so custom getComments() items appear without polling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105.
Problem
There was no way to reload
<livewire:commentions.comments>immediately after saving the record. CustomgetComments()items (e.g. activity-log status changes) only appeared after the next poll.Fix
Listen for a public
commentions:refreshLivewire event:CommentListreloads its computed commentsCommentsforwards the event ascomment:savedso targeting the parent component still refreshes the nested listTests
commentions:refreshis dispatchedcommentions:refreshascomment:savedFull suite: 182 passed. Pint clean. PHPStan unchanged — the 7 pre-existing errors in
tests/Livewire/CommentReactionTest.phpare also present onmain.