Repository navigation
fix: Honor visible()/hidden() on comment actions and default size to xs - #123
Merged
Merged
Conversation
Filament icon-button actions render hidden actions as disabled rather
than omitting them. Skip rendering actions that are not visible so
visible()/hidden() actually hide the button.
Custom actions also inherit defaultSize('xs') to match edit/delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
Problem
Two issues with custom comment actions:
visible()/hidden()disable instead of hide. Filament's icon-buttontoHtml()does not skip hidden actions — it only checksisDisabled(), andisDisabled()returns true when the action is hidden. Rendering{{ $action }}therefore produced a disabled button. The same applied to edit/delete for users who cannot update/delete.Default size is larger than edit/delete. Built-in actions set
size('xs'). Custom actions used Filament's medium default unless the host set size explicitly.Fix
isVisible()is truedefaultSize('xs')to custom actions so they match edit/delete unless the host overrides with->size()Tests
visible()closures that inspect the comment)xs; an explicitsize('sm')is preservedFull suite: 174 passed. Pint clean. PHPStan unchanged — the 7 pre-existing errors in
tests/Livewire/CommentReactionTest.phpare also present onmain.