Repository navigation
fix: Resolve author name via Manager and handle deleted authors - #122
Merged
Merged
Conversation
getAuthorName() read $this->author->name directly, which fatals when the author is missing and ignores getCommenterName()/HasName. Route through Manager::getName() and fall back to a translated label; guard avatar generation the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121.
Problem
Comment::getAuthorName()read$this->author->namedirectly. That:$this->authoris null)getCommenterName()/ FilamentHasNamecustomizations, so the displayed name can disagree with mentions and avatars (which already go throughManager::getName())getAuthorAvatar()had the same null-author crash viaManager::getName($this->author).Fix
Manager::getName(), with a translateddeleted_userfallback when the author is missing or unnamedgetAuthorName()Tests
tests/CommentAuthorNameTest.php: defaultname,getCommenterName(),HasName, deleted author name + avatarFull suite: 175 passed. Pint clean. PHPStan unchanged — the 7 pre-existing errors in
tests/Livewire/CommentReactionTest.phpare also present onmain.