Repository navigation
fix(zx): print command stdout in Script and Commands examples - #477
Merged
fdelbrayelle merged 1 commit intoOct 28, 2026
Merged
Conversation
kestrabot
Bot
added
area/plugin
fdelbrayelle
left a comment
fdelbrayelle
left a comment
Member
There was a problem hiding this comment.
Kestra Plugin Code Review
Business Requirements — met
Both zx @Example flows (Script, Commands) now print the command stdout with console.log(result.stdout.trim()), which is the fix suggested in #476. The change touches only the two example strings: no build, CI, or runtime code changes.
Kestra Guidelines — 0 findings
✅ No violations. Examples stay full runnable flows with id, namespace, full = true, no lang, and closing """ aligned with the flow id.
Security (OWASP Top 10:2025 + KPS) — 0 findings
✅ No issues found. The examples interpolate only a local JS constant inside a zx template literal, which zx escapes, and no {{ inputs.* }} value reaches a shell (KPS-06).
Performance — 0 findings
✅ No issues found
Verdict: APPROVE; recommendation only, posted as COMMENT, a maintainer decides.
Confidence: 100%
fdelbrayelle
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
io.kestra.plugin.scripts.zx.Scriptandio.kestra.plugin.scripts.zx.Commands, the@Exampleflows executedawait $\echo ...`` without printing the result. Because zx 8 does not print command stdout unless explicitly output or verbose mode is enabled, running the example flows produced no output logs.This PR updates the example code in both classes to capture and log the command stdout via
console.log(result.stdout.trim())so that users copying the example see the expected log lines.Closes #476.